提交 bea28e65 编写于 作者: F Florian Grandel 提交者: Marcel Holtmann

Bluetooth: mgmt: improve get_adv_instance_flags() readability

Switch if and else conditions to replace a negative statement by a
positive one which makes the condition more readable.
Signed-off-by: NFlorian Grandel <fgrandel@gmail.com>
Signed-off-by: NMarcel Holtmann <marcel@holtmann.org>
上级 411b4121
...@@ -962,26 +962,28 @@ static u32 get_adv_instance_flags(struct hci_dev *hdev, u8 instance) ...@@ -962,26 +962,28 @@ static u32 get_adv_instance_flags(struct hci_dev *hdev, u8 instance)
u32 flags; u32 flags;
struct adv_info *adv_instance; struct adv_info *adv_instance;
if (instance != 0x00) { if (instance == 0x00) {
adv_instance = hci_find_adv_instance(hdev, instance); /* Instance 0 always manages the "Tx Power" and "Flags"
* fields
*/
flags = MGMT_ADV_FLAG_TX_POWER | MGMT_ADV_FLAG_MANAGED_FLAGS;
/* Return 0 when we got an invalid instance identifier. */ /* For instance 0, the HCI_ADVERTISING_CONNECTABLE setting
if (!adv_instance) * corresponds to the "connectable" instance flag.
return 0; */
if (hci_dev_test_flag(hdev, HCI_ADVERTISING_CONNECTABLE))
flags |= MGMT_ADV_FLAG_CONNECTABLE;
return adv_instance->flags; return flags;
} }
/* Instance 0 always manages the "Tx Power" and "Flags" fields */ adv_instance = hci_find_adv_instance(hdev, instance);
flags = MGMT_ADV_FLAG_TX_POWER | MGMT_ADV_FLAG_MANAGED_FLAGS;
/* For instance 0, the HCI_ADVERTISING_CONNECTABLE setting corresponds /* Return 0 when we got an invalid instance identifier. */
* to the "connectable" instance flag. if (!adv_instance)
*/ return 0;
if (hci_dev_test_flag(hdev, HCI_ADVERTISING_CONNECTABLE))
flags |= MGMT_ADV_FLAG_CONNECTABLE;
return flags; return adv_instance->flags;
} }
static u8 get_adv_instance_scan_rsp_len(struct hci_dev *hdev, u8 instance) static u8 get_adv_instance_scan_rsp_len(struct hci_dev *hdev, u8 instance)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册