提交 b79f0438 编写于 作者: T Thomas Gleixner 提交者: Lee Jones

mfd: pm8921: Consolidate chained IRQ handler install/remove

Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.
Reported-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
上级 59fa909e
...@@ -371,14 +371,12 @@ static int pm8921_probe(struct platform_device *pdev) ...@@ -371,14 +371,12 @@ static int pm8921_probe(struct platform_device *pdev)
if (!chip->irqdomain) if (!chip->irqdomain)
return -ENODEV; return -ENODEV;
irq_set_handler_data(irq, chip); irq_set_chained_handler_and_data(irq, pm8xxx_irq_handler, chip);
irq_set_chained_handler(irq, pm8xxx_irq_handler);
irq_set_irq_wake(irq, 1); irq_set_irq_wake(irq, 1);
rc = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); rc = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
if (rc) { if (rc) {
irq_set_chained_handler(irq, NULL); irq_set_chained_handler_and_data(irq, NULL, NULL);
irq_set_handler_data(irq, NULL);
irq_domain_remove(chip->irqdomain); irq_domain_remove(chip->irqdomain);
} }
...@@ -397,8 +395,7 @@ static int pm8921_remove(struct platform_device *pdev) ...@@ -397,8 +395,7 @@ static int pm8921_remove(struct platform_device *pdev)
struct pm_irq_chip *chip = platform_get_drvdata(pdev); struct pm_irq_chip *chip = platform_get_drvdata(pdev);
device_for_each_child(&pdev->dev, NULL, pm8921_remove_child); device_for_each_child(&pdev->dev, NULL, pm8921_remove_child);
irq_set_chained_handler(irq, NULL); irq_set_chained_handler_and_data(irq, NULL, NULL);
irq_set_handler_data(irq, NULL);
irq_domain_remove(chip->irqdomain); irq_domain_remove(chip->irqdomain);
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册