提交 b2c064b2 编写于 作者: R Rafael J. Wysocki

Driver core / memory: Simplify __memory_block_change_state()

As noted by Tang Chen, the last_online field in struct memory_block
introduced by commit 4960e05e (Driver core: Introduce offline/online
callbacks for memory blocks) is not really necessary, because
online_pages() restores the previous state if passed ONLINE_KEEP as
the last argument.  Therefore, remove that field along with the code
referring to it.

References: http://marc.info/?l=linux-kernel&m=136919777305599&w=2Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: NTang Chen <tangchen@cn.fujitsu.com>
上级 2e4f1db4
...@@ -291,13 +291,7 @@ static int __memory_block_change_state(struct memory_block *mem, ...@@ -291,13 +291,7 @@ static int __memory_block_change_state(struct memory_block *mem,
mem->state = MEM_GOING_OFFLINE; mem->state = MEM_GOING_OFFLINE;
ret = memory_block_action(mem->start_section_nr, to_state, online_type); ret = memory_block_action(mem->start_section_nr, to_state, online_type);
if (ret) { mem->state = ret ? from_state_req : to_state;
mem->state = from_state_req;
} else {
mem->state = to_state;
if (to_state == MEM_ONLINE)
mem->last_online = online_type;
}
return ret; return ret;
} }
...@@ -310,7 +304,7 @@ static int memory_subsys_online(struct device *dev) ...@@ -310,7 +304,7 @@ static int memory_subsys_online(struct device *dev)
ret = mem->state == MEM_ONLINE ? 0 : ret = mem->state == MEM_ONLINE ? 0 :
__memory_block_change_state(mem, MEM_ONLINE, MEM_OFFLINE, __memory_block_change_state(mem, MEM_ONLINE, MEM_OFFLINE,
mem->last_online); ONLINE_KEEP);
mutex_unlock(&mem->state_mutex); mutex_unlock(&mem->state_mutex);
return ret; return ret;
...@@ -618,7 +612,6 @@ static int init_memory_block(struct memory_block **memory, ...@@ -618,7 +612,6 @@ static int init_memory_block(struct memory_block **memory,
base_memory_block_id(scn_nr) * sections_per_block; base_memory_block_id(scn_nr) * sections_per_block;
mem->end_section_nr = mem->start_section_nr + sections_per_block - 1; mem->end_section_nr = mem->start_section_nr + sections_per_block - 1;
mem->state = state; mem->state = state;
mem->last_online = ONLINE_KEEP;
mem->section_count++; mem->section_count++;
mutex_init(&mem->state_mutex); mutex_init(&mem->state_mutex);
start_pfn = section_nr_to_pfn(mem->start_section_nr); start_pfn = section_nr_to_pfn(mem->start_section_nr);
......
...@@ -26,7 +26,6 @@ struct memory_block { ...@@ -26,7 +26,6 @@ struct memory_block {
unsigned long start_section_nr; unsigned long start_section_nr;
unsigned long end_section_nr; unsigned long end_section_nr;
unsigned long state; unsigned long state;
int last_online;
int section_count; int section_count;
/* /*
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册