提交 b139f1fb 编写于 作者: N Nathan Lynch 提交者: Paul Mackerras

[POWERPC] Remove gratuitous reads from pasemi pci config space methods

The pasemi pci configuration space write method reads the written
location immediately after the write is performed, presumably in order
to flush the write.  However, configuration space writes are not
allowed to be posted, making these reads gratuitous.  Furthermore,
this behavior potentially causes us to violate the PCI PM spec when
changing between e.g. D0 and D3 states, because a delay of up to 10ms
may be required before the OS accesses configuration space after the
write which initiates the transition.

Remove the unnecessary reads from pa_pxp_write_config.
Signed-off-by: NNathan Lynch <ntl@pobox.com>
Acked-by: NOlof Johansson <olof@lixom.net>
Signed-off-by: NPaul Mackerras <paulus@samba.org>
上级 8935fa0f
...@@ -107,15 +107,12 @@ static int pa_pxp_write_config(struct pci_bus *bus, unsigned int devfn, ...@@ -107,15 +107,12 @@ static int pa_pxp_write_config(struct pci_bus *bus, unsigned int devfn,
switch (len) { switch (len) {
case 1: case 1:
out_8(addr, val); out_8(addr, val);
(void) in_8(addr);
break; break;
case 2: case 2:
out_le16(addr, val); out_le16(addr, val);
(void) in_le16(addr);
break; break;
default: default:
out_le32(addr, val); out_le32(addr, val);
(void) in_le32(addr);
break; break;
} }
return PCIBIOS_SUCCESSFUL; return PCIBIOS_SUCCESSFUL;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册