提交 adb31be4 编写于 作者: R Roman Gushchin 提交者: Shuah Khan (Samsung OSG)

kselftest/cgroup: fix variable dereferenced before check warning

cg_name(const char *root, const char *name) is always called with
non-empty root and name arguments, so there is no sense in checking
it in the function body (after using in strlen()).
Signed-off-by: NRoman Gushchin <guro@fb.com>
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NShuah Khan (Samsung OSG) <shuah@kernel.org>
上级 7b04d1e9
......@@ -59,8 +59,7 @@ char *cg_name(const char *root, const char *name)
size_t len = strlen(root) + strlen(name) + 2;
char *ret = malloc(len);
if (name)
snprintf(ret, len, "%s/%s", root, name);
snprintf(ret, len, "%s/%s", root, name);
return ret;
}
......@@ -70,8 +69,7 @@ char *cg_name_indexed(const char *root, const char *name, int index)
size_t len = strlen(root) + strlen(name) + 10;
char *ret = malloc(len);
if (name)
snprintf(ret, len, "%s/%s_%d", root, name, index);
snprintf(ret, len, "%s/%s_%d", root, name, index);
return ret;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册