提交 ad6d8004 编写于 作者: B Bartosz Golaszewski 提交者: Linus Walleij

gpio: mockup: dynamically allocate memory for chip name

Currently the chip name buffer is allocated on the stack and the
address of the buffer is passed to the gpio framework. It's invalid
after probe() returns, so the sysfs label attribute displays garbage.

Use devm_kasprintf() for each string instead.
Signed-off-by: NBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
上级 e53c6028
...@@ -126,7 +126,7 @@ static int mockup_gpio_probe(struct platform_device *pdev) ...@@ -126,7 +126,7 @@ static int mockup_gpio_probe(struct platform_device *pdev)
int i; int i;
int base; int base;
int ngpio; int ngpio;
char chip_name[sizeof(GPIO_NAME) + 3]; char *chip_name;
if (gpio_mockup_params_nr < 2) if (gpio_mockup_params_nr < 2)
return -EINVAL; return -EINVAL;
...@@ -146,8 +146,12 @@ static int mockup_gpio_probe(struct platform_device *pdev) ...@@ -146,8 +146,12 @@ static int mockup_gpio_probe(struct platform_device *pdev)
ngpio = gpio_mockup_ranges[i * 2 + 1] - base; ngpio = gpio_mockup_ranges[i * 2 + 1] - base;
if (ngpio >= 0) { if (ngpio >= 0) {
sprintf(chip_name, "%s-%c", GPIO_NAME, chip_name = devm_kasprintf(dev, GFP_KERNEL,
pins_name_start + i); "%s-%c", GPIO_NAME,
pins_name_start + i);
if (!chip_name)
return -ENOMEM;
ret = mockup_gpio_add(dev, &cntr[i], ret = mockup_gpio_add(dev, &cntr[i],
chip_name, base, ngpio); chip_name, base, ngpio);
} else { } else {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册