提交 93b83005 编写于 作者: P Peter Rosin 提交者: Greg Kroah-Hartman

lib/test_string.c: avoid masking memset16/32/64 failures

[ Upstream commit 33d6e0ff68af74be0c846c8e042e84a9a1a0561e ]

If a memsetXX implementation is completely broken and fails in the first
iteration, when i, j, and k are all zero, the failure is masked as zero
is returned.  Failing in the first iteration is perhaps the most likely
failure, so this makes the tests pretty much useless.  Avoid the
situation by always setting a random unused bit in the result on
failure.

Link: http://lkml.kernel.org/r/20190506124634.6807-3-peda@axentia.se
Fixes: 03270c13 ("lib/string.c: add testcases for memset16/32/64")
Signed-off-by: NPeter Rosin <peda@axentia.se>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: NSasha Levin <sashal@kernel.org>
上级 8e087a2a
......@@ -35,7 +35,7 @@ static __init int memset16_selftest(void)
fail:
kfree(p);
if (i < 256)
return (i << 24) | (j << 16) | k;
return (i << 24) | (j << 16) | k | 0x8000;
return 0;
}
......@@ -71,7 +71,7 @@ static __init int memset32_selftest(void)
fail:
kfree(p);
if (i < 256)
return (i << 24) | (j << 16) | k;
return (i << 24) | (j << 16) | k | 0x8000;
return 0;
}
......@@ -107,7 +107,7 @@ static __init int memset64_selftest(void)
fail:
kfree(p);
if (i < 256)
return (i << 24) | (j << 16) | k;
return (i << 24) | (j << 16) | k | 0x8000;
return 0;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册