uprobes: __create_xol_area() must nullify xol_mapping.fault
As Jiri pointed out, this recent commit: f872f540 ("mm: Add a vm_special_mapping.fault() method") breaks uprobes: __create_xol_area() doesn't initialize the new ->fault() method and this obviously leads to kernel crash when the application tries to execute the probed insn after bp hit. We probably want to add uprobes_special_mapping_fault(), this allows to turn xol_area->xol_mapping into a single instance of vm_special_mapping. But we need a simple fix, so lets change __create_xol() to nullify the new member as Jiri suggests. Suggested-by: NJiri Olsa <jolsa@redhat.com> Reported-by: NJiri Olsa <jolsa@redhat.com> Signed-off-by: NOleg Nesterov <oleg@redhat.com> Cc: Andy Lutomirski <tipbot@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Pratyush Anand <panand@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20160227221128.GA29565@redhat.comSigned-off-by: NIngo Molnar <mingo@kernel.org>
Showing
想要评论请 注册 或 登录