提交 820ec411 编写于 作者: S Sebastian Andrzej Siewior 提交者: David S. Miller

alim15x3: move irq-restore before pci_dev_put()

init_chipset_ali15x3() initializes the chipset during init with disabled
interrupts. There is no need to keep the interrupts disabled during
pci_dev_put().
Move the irq-restore before pci_dev_put() is invoked.

Side note: The same init is performed in
drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts.
It looks that the same hardware is supported in the ATA land. Would it
make sense to remove this driver since it is supported in the other
subsystem?
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: NDavid S. Miller <davem@davemloft.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 5037be16
...@@ -323,9 +323,9 @@ static int init_chipset_ali15x3(struct pci_dev *dev) ...@@ -323,9 +323,9 @@ static int init_chipset_ali15x3(struct pci_dev *dev)
pci_write_config_byte(dev, 0x53, tmpbyte); pci_write_config_byte(dev, 0x53, tmpbyte);
} }
local_irq_restore(flags);
pci_dev_put(north); pci_dev_put(north);
pci_dev_put(isa_dev); pci_dev_put(isa_dev);
local_irq_restore(flags);
return 0; return 0;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册