提交 80d11788 编写于 作者: D David S. Miller

Revert "drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister before mdiobus_free"

This reverts commit aa731872.

As pointed out by Ben Hutchings, this change is not correct.

mdiobus_unregister() can't be called if the bus isn't registered yet,
however this change can result in situations which cause that to
happen.

Part of the confusion here revolves around the fact that the
callers of this module control registration/unregistration,
rather than the module itself.
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 769ce4c9
...@@ -234,7 +234,6 @@ void free_mdio_bitbang(struct mii_bus *bus) ...@@ -234,7 +234,6 @@ void free_mdio_bitbang(struct mii_bus *bus)
struct mdiobb_ctrl *ctrl = bus->priv; struct mdiobb_ctrl *ctrl = bus->priv;
module_put(ctrl->ops->owner); module_put(ctrl->ops->owner);
mdiobus_unregister(bus);
mdiobus_free(bus); mdiobus_free(bus);
} }
EXPORT_SYMBOL(free_mdio_bitbang); EXPORT_SYMBOL(free_mdio_bitbang);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册