提交 7adb92fa 编写于 作者: M Michael Büsch 提交者: John W. Linville

p54spi: Remove FIXME in op_stop

Don't use the interruptible variant of mutex_lock(). It doesn't really
need to be interruptible. This avoids nasty error handling.
Signed-off-by: NMichael Buesch <m@bues.ch>
Acked-by: NChristian Lamparter <chunkeey@googlemail.com>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
上级 fcac4fb0
...@@ -581,11 +581,7 @@ static void p54spi_op_stop(struct ieee80211_hw *dev) ...@@ -581,11 +581,7 @@ static void p54spi_op_stop(struct ieee80211_hw *dev)
struct p54s_priv *priv = dev->priv; struct p54s_priv *priv = dev->priv;
unsigned long flags; unsigned long flags;
if (mutex_lock_interruptible(&priv->mutex)) { mutex_lock(&priv->mutex);
/* FIXME: how to handle this error? */
return;
}
WARN_ON(priv->fw_state != FW_STATE_READY); WARN_ON(priv->fw_state != FW_STATE_READY);
cancel_work_sync(&priv->work); cancel_work_sync(&priv->work);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册