提交 7ad94699 编写于 作者: F Finn Thain 提交者: Michael Ellerman

macintosh/via-pmu: Don't clear shift register interrupt flag twice

The shift register interrupt flag gets cleared in via_pmu_interrupt()
and once again in pmu_sr_intr(). Fix this theoretical race condition.
Tested-by: NStan Johnson <userm57@yahoo.com>
Signed-off-by: NFinn Thain <fthain@telegraphics.com.au>
Reviewed-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
上级 576d5290
...@@ -1421,7 +1421,6 @@ pmu_sr_intr(void) ...@@ -1421,7 +1421,6 @@ pmu_sr_intr(void)
if (in_8(&via[B]) & TREQ) { if (in_8(&via[B]) & TREQ) {
printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B])); printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B]));
out_8(&via[IFR], SR_INT);
return NULL; return NULL;
} }
/* The ack may not yet be low when we get the interrupt */ /* The ack may not yet be low when we get the interrupt */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册