提交 7aabe84b 编写于 作者: J James Smart 提交者: Martin K. Petersen

scsi: lpfc: sanity check hrq is null before dereferencing it

From: Colin Ian King <colin.king@canonical.com>

The sanity check for hrq should be moved to before the deference
of hrq to ensure we don't perform a null pointer deference.

Detected by CoverityScan, CID#1411650 ("Dereference before null check")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NJames Smart <james.smart@broadcom.com>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
上级 70e5afd5
...@@ -15185,17 +15185,17 @@ lpfc_mrq_create(struct lpfc_hba *phba, struct lpfc_queue **hrqp, ...@@ -15185,17 +15185,17 @@ lpfc_mrq_create(struct lpfc_hba *phba, struct lpfc_queue **hrqp,
drq = drqp[idx]; drq = drqp[idx];
cq = cqp[idx]; cq = cqp[idx];
if (hrq->entry_count != drq->entry_count) {
status = -EINVAL;
goto out;
}
/* sanity check on queue memory */ /* sanity check on queue memory */
if (!hrq || !drq || !cq) { if (!hrq || !drq || !cq) {
status = -ENODEV; status = -ENODEV;
goto out; goto out;
} }
if (hrq->entry_count != drq->entry_count) {
status = -EINVAL;
goto out;
}
if (idx == 0) { if (idx == 0) {
bf_set(lpfc_mbx_rq_create_num_pages, bf_set(lpfc_mbx_rq_create_num_pages,
&rq_create->u.request, &rq_create->u.request,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册