提交 7648cdfe 编写于 作者: L Lars Ellenberg 提交者: Philipp Reisner

drbd: be less noisy with some log messages

We expect changes to a bitmap page in drbd_bm_write_page,
that's why we submit a copy page.

If a page changes during global writeout, that would be unexpected,
and reason to warn, though.

Also, often page writeout can be skipped (on activity log transactions
during normal operation, for example), no need to log that everytime.
Signed-off-by: NPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: NLars Ellenberg <lars.ellenberg@linbit.com>
上级 5a22db89
......@@ -920,8 +920,9 @@ static void bm_async_io_complete(struct bio *bio, int error)
if (!error && !uptodate)
error = -EIO;
if (!bm_test_page_unchanged(b->bm_pages[idx]))
dev_info(DEV, "bitmap page idx %u changed during IO!\n", idx);
if ((ctx->flags & BM_AIO_COPY_PAGES) == 0 &&
!bm_test_page_unchanged(b->bm_pages[idx]))
dev_warn(DEV, "bitmap page idx %u changed during IO!\n", idx);
if (error) {
/* ctx error will hold the completed-last non-zero error code,
......@@ -1135,7 +1136,7 @@ int drbd_bm_write_page(struct drbd_conf *mdev, unsigned int idx) __must_hold(loc
struct bm_aio_ctx ctx = { .flags = BM_AIO_COPY_PAGES, };
if (bm_test_page_unchanged(mdev->bitmap->bm_pages[idx])) {
dev_info(DEV, "skipped bm page write for idx %u\n", idx);
dynamic_dev_dbg(DEV, "skipped bm page write for idx %u\n", idx);
return 0;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册