提交 74573ee7 编写于 作者: A Alexey Dobriyan 提交者: Greg Kroah-Hartman

USB: cdc-acm: don't unlock acm->mutex on error path

On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote:
> I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify"
> and the kernel oopsed:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000458
> IP: [<c0444b52>] mutex_unlock+0x0/0xb
>  [<c03830ae>] acm_tty_open+0x4c/0x214
Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>
Tested-by: NAndrei Popa <andrei.popa@i-neo.ro>
Cc: stable <stable@kernel.org>		[2.6.25.x, 2.6.26.x]
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
上级 fb85d991
...@@ -589,8 +589,8 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp) ...@@ -589,8 +589,8 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
tasklet_schedule(&acm->urb_task); tasklet_schedule(&acm->urb_task);
done: done:
err_out:
mutex_unlock(&acm->mutex); mutex_unlock(&acm->mutex);
err_out:
mutex_unlock(&open_mutex); mutex_unlock(&open_mutex);
return rv; return rv;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册