提交 61d6ab62 编写于 作者: J Jules Irenge 提交者: Shile Zhang

mm/compaction: add missing annotation for compact_lock_irqsave

to #26255339

commit 77337edee7598d82fb5acf66cb91a5b3f0c46add upstream

Sparse reports a warning at compact_lock_irqsave()

warning: context imbalance in compact_lock_irqsave() - wrong count at exit

The root cause is the missing annotation at compact_lock_irqsave()
Add the missing __acquires(lock) annotation.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200214204741.94112-6-jbi.octave@gmail.comSigned-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: NYang Shi <yang.shi@linux.alibaba.com>
Reviewed-by: NXunlei Pang <xlpang@linux.alibaba.com>
上级 a5c295c0
...@@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page, ...@@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page,
*/ */
static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags,
struct compact_control *cc) struct compact_control *cc)
__acquires(lock)
{ {
/* Track if the lock is contended in async mode */ /* Track if the lock is contended in async mode */
if (cc->mode == MIGRATE_ASYNC && !cc->contended) { if (cc->mode == MIGRATE_ASYNC && !cc->contended) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册