提交 5dfdd24e 编写于 作者: J Johan Hovold

USB: serial: ti_usb_3410_5052: fix array underflow in completion handler

Similarly to a recently reported bug in io_ti, a malicious USB device
could set port_number to a negative value and we would underflow the
port array in the interrupt completion handler.

As these devices only have one or two ports, fix this by making sure we
only consider the seventh bit when determining the port number (and
ignore bits 0xb0 which are typically set to 0x30).

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NJohan Hovold <johan@kernel.org>
上级 691a03cf
...@@ -1119,7 +1119,7 @@ static void ti_break(struct tty_struct *tty, int break_state) ...@@ -1119,7 +1119,7 @@ static void ti_break(struct tty_struct *tty, int break_state)
static int ti_get_port_from_code(unsigned char code) static int ti_get_port_from_code(unsigned char code)
{ {
return (code >> 4) - 3; return (code >> 6) & 0x01;
} }
static int ti_get_func_from_code(unsigned char code) static int ti_get_func_from_code(unsigned char code)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册