提交 5cfdc142 编写于 作者: D Darrick J. Wong 提交者: Jeffle Xu

xfs: fix partially uninitialized structure in xfs_reflink_remap_extent

task #28557760

[ Upstream commit c142932c29e533ee892f87b44d8abc5719edceec ]

In the reflink extent remap function, it turns out that uirec (the block
mapping corresponding only to the part of the passed-in mapping that got
unmapped) was not fully initialized.  Specifically, br_state was not
being copied from the passed-in struct to the uirec.  This could lead to
unpredictable results such as the reflinked mapping being marked
unwritten in the destination file.
Signed-off-by: NDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: NBrian Foster <bfoster@redhat.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NJeffle Xu <jefflexu@linux.alibaba.com>
Acked-by: NJoseph Qi <joseph.qi@linux.alibaba.com>
上级 0ff2b809
...@@ -1058,6 +1058,7 @@ xfs_reflink_remap_extent( ...@@ -1058,6 +1058,7 @@ xfs_reflink_remap_extent(
uirec.br_startblock = irec->br_startblock + rlen; uirec.br_startblock = irec->br_startblock + rlen;
uirec.br_startoff = irec->br_startoff + rlen; uirec.br_startoff = irec->br_startoff + rlen;
uirec.br_blockcount = unmap_len - rlen; uirec.br_blockcount = unmap_len - rlen;
uirec.br_state = irec->br_state;
unmap_len = rlen; unmap_len = rlen;
/* If this isn't a real mapping, we're done. */ /* If this isn't a real mapping, we're done. */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册