提交 59a8f43b 编写于 作者: M Matias Bjørling 提交者: Jens Axboe

lightnvm: limit get chunk meta request size

For devices that does not specify a limit on its transfer size, the
get_chk_meta command may send down a single I/O retrieving the full
chunk metadata table. Resulting in large 2-4MB I/O requests. Instead,
split up the I/Os to a maximum of 256KB and issue them separately to
reduce memory requirements.
Signed-off-by: NMatias Bjørling <mb@lightnvm.io>
Reviewed-by: NJavier González <javier@cnexlabs.com>
Signed-off-by: NJens Axboe <axboe@kernel.dk>
上级 921aebfa
...@@ -583,7 +583,13 @@ static int nvme_nvm_get_chk_meta(struct nvm_dev *ndev, ...@@ -583,7 +583,13 @@ static int nvme_nvm_get_chk_meta(struct nvm_dev *ndev,
struct ppa_addr ppa; struct ppa_addr ppa;
size_t left = nchks * sizeof(struct nvme_nvm_chk_meta); size_t left = nchks * sizeof(struct nvme_nvm_chk_meta);
size_t log_pos, offset, len; size_t log_pos, offset, len;
int ret, i; int ret, i, max_len;
/*
* limit requests to maximum 256K to avoid issuing arbitrary large
* requests when the device does not specific a maximum transfer size.
*/
max_len = min_t(unsigned int, ctrl->max_hw_sectors << 9, 256 * 1024);
/* Normalize lba address space to obtain log offset */ /* Normalize lba address space to obtain log offset */
ppa.ppa = slba; ppa.ppa = slba;
...@@ -596,7 +602,7 @@ static int nvme_nvm_get_chk_meta(struct nvm_dev *ndev, ...@@ -596,7 +602,7 @@ static int nvme_nvm_get_chk_meta(struct nvm_dev *ndev,
offset = log_pos * sizeof(struct nvme_nvm_chk_meta); offset = log_pos * sizeof(struct nvme_nvm_chk_meta);
while (left) { while (left) {
len = min_t(unsigned int, left, ctrl->max_hw_sectors << 9); len = min_t(unsigned int, left, max_len);
ret = nvme_get_log_ext(ctrl, ns, NVME_NVM_LOG_REPORT_CHUNK, ret = nvme_get_log_ext(ctrl, ns, NVME_NVM_LOG_REPORT_CHUNK,
dev_meta, len, offset); dev_meta, len, offset);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册