提交 539a06ba 编写于 作者: S Sabrina Dubroca 提交者: David S. Miller

tcp: ulp: avoid module refcnt leak in tcp_set_ulp

__tcp_ulp_find_autoload returns tcp_ulp_ops after taking a reference on
the module. Then, if ->init fails, tcp_set_ulp propagates the error but
nothing releases that reference.

Fixes: 734942cc ("tcp: ULP infrastructure")
Signed-off-by: NSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 bae514a6
...@@ -122,14 +122,14 @@ int tcp_set_ulp(struct sock *sk, const char *name) ...@@ -122,14 +122,14 @@ int tcp_set_ulp(struct sock *sk, const char *name)
ulp_ops = __tcp_ulp_find_autoload(name); ulp_ops = __tcp_ulp_find_autoload(name);
if (!ulp_ops) if (!ulp_ops)
err = -ENOENT; return -ENOENT;
else
err = ulp_ops->init(sk);
if (err) err = ulp_ops->init(sk);
goto out; if (err) {
module_put(ulp_ops->owner);
return err;
}
icsk->icsk_ulp_ops = ulp_ops; icsk->icsk_ulp_ops = ulp_ops;
out: return 0;
return err;
} }
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册