提交 48659ebf 编写于 作者: J Jin Yao 提交者: Arnaldo Carvalho de Melo

perf annotate: Record the min/max cycles

Currently perf has a feature to account cycles for LBRs

For example, on skylake:

  perf record -b ...
  perf report or perf annotate

And then browsing the annotate browser gives average cycle counts for
program blocks.

For some analysis it would be useful if we could know not only the
average cycles but also the min and max cycles.

This patch records the min and max cycles.
Signed-off-by: NJin Yao <yao.jin@linux.intel.com>
Tested-by: NArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1526569118-14217-2-git-send-email-yao.jin@linux.intel.com
[ Switch from max/min to min/max ]
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
上级 7903a708
...@@ -760,6 +760,15 @@ static int __symbol__account_cycles(struct annotation *notes, ...@@ -760,6 +760,15 @@ static int __symbol__account_cycles(struct annotation *notes,
ch[offset].num_aggr++; ch[offset].num_aggr++;
ch[offset].cycles_aggr += cycles; ch[offset].cycles_aggr += cycles;
if (cycles > ch[offset].cycles_max)
ch[offset].cycles_max = cycles;
if (ch[offset].cycles_min) {
if (cycles && cycles < ch[offset].cycles_min)
ch[offset].cycles_min = cycles;
} else
ch[offset].cycles_min = cycles;
if (!have_start && ch[offset].have_start) if (!have_start && ch[offset].have_start)
return 0; return 0;
if (ch[offset].num) { if (ch[offset].num) {
...@@ -953,8 +962,11 @@ void annotation__compute_ipc(struct annotation *notes, size_t size) ...@@ -953,8 +962,11 @@ void annotation__compute_ipc(struct annotation *notes, size_t size)
if (ch->have_start) if (ch->have_start)
annotation__count_and_fill(notes, ch->start, offset, ch); annotation__count_and_fill(notes, ch->start, offset, ch);
al = notes->offsets[offset]; al = notes->offsets[offset];
if (al && ch->num_aggr) if (al && ch->num_aggr) {
al->cycles = ch->cycles_aggr / ch->num_aggr; al->cycles = ch->cycles_aggr / ch->num_aggr;
al->cycles_max = ch->cycles_max;
al->cycles_min = ch->cycles_min;
}
notes->have_cycles = true; notes->have_cycles = true;
} }
} }
......
...@@ -105,6 +105,8 @@ struct annotation_line { ...@@ -105,6 +105,8 @@ struct annotation_line {
int jump_sources; int jump_sources;
float ipc; float ipc;
u64 cycles; u64 cycles;
u64 cycles_max;
u64 cycles_min;
size_t privsize; size_t privsize;
char *path; char *path;
u32 idx; u32 idx;
...@@ -186,6 +188,8 @@ struct cyc_hist { ...@@ -186,6 +188,8 @@ struct cyc_hist {
u64 start; u64 start;
u64 cycles; u64 cycles;
u64 cycles_aggr; u64 cycles_aggr;
u64 cycles_max;
u64 cycles_min;
u32 num; u32 num;
u32 num_aggr; u32 num_aggr;
u8 have_start; u8 have_start;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册