提交 3fc3a0be 编写于 作者: G Geert Uytterhoeven 提交者: Rafael J. Wysocki

PM / clk: Fix clock error check in __pm_clk_add()

In the final iteration of commit 245bd6f6 ("PM / clock_ops: Add
pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko.
However, the accompanying IS_ERR() check operates on the wrong clock
pointer, which is always zero at this point, i.e. not an error.
This may lead to a NULL pointer dereference later, when __clk_get()
tries to dereference an error pointer.

Check the passed clock pointer instead to fix this.
Signed-off-by: NGeert Uytterhoeven <geert+renesas@glider.be>
Fixes: 245bd6f6 ("PM / clock_ops: Add pm_clk_add_clk()")
Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
上级 d2c4b43d
......@@ -94,7 +94,7 @@ static int __pm_clk_add(struct device *dev, const char *con_id,
return -ENOMEM;
}
} else {
if (IS_ERR(ce->clk) || !__clk_get(clk)) {
if (IS_ERR(clk) || !__clk_get(clk)) {
kfree(ce);
return -ENOENT;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册