提交 3dfbac0a 编写于 作者: C Colin Ian King 提交者: Greg Kroah-Hartman

media: vsp1: fix memory leak of dl on error return path

[ Upstream commit 70c55c1ad1a76e804ee5330e134674f5d2741cb7 ]

Currently when the call vsp1_dl_body_get fails and returns null the
error return path leaks the allocation of dl. Fix this by kfree'ing
dl before returning.

Addresses-Coverity: ("Resource leak")

Fixes: 5d7936b8 ("media: vsp1: Convert display lists to use new body pool")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Reviewed-by: NKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: NLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: NSasha Levin <sashal@kernel.org>
上级 c47022e0
...@@ -557,8 +557,10 @@ static struct vsp1_dl_list *vsp1_dl_list_alloc(struct vsp1_dl_manager *dlm) ...@@ -557,8 +557,10 @@ static struct vsp1_dl_list *vsp1_dl_list_alloc(struct vsp1_dl_manager *dlm)
/* Get a default body for our list. */ /* Get a default body for our list. */
dl->body0 = vsp1_dl_body_get(dlm->pool); dl->body0 = vsp1_dl_body_get(dlm->pool);
if (!dl->body0) if (!dl->body0) {
kfree(dl);
return NULL; return NULL;
}
header_offset = dl->body0->max_entries * sizeof(*dl->body0->entries); header_offset = dl->body0->max_entries * sizeof(*dl->body0->entries);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册