提交 38fc0026 编写于 作者: N Nicolas de Pesloüan 提交者: David S. Miller

bonding: change bond_create_proc_entry() to return void

The function bond_create_proc_entry is currently of type int.

Two versions of this function exist:

The one in the ifdef CONFIG_PROC_FS branch always return 0.
The one in the else branch (which is empty) return nothing.

When CONFIG_PROC_FS is undef, this cause the following warning:

drivers/net/bonding/bond_main.c: In function `bond_create_proc_entry':
drivers/net/bonding/bond_main.c:3393: warning: control reaches end of
non-void function

No caller of this function use the returned value.

So change the returned type from int to void and remove the
useless return 0; .
Signed-off-by: NNicolas de Pesloüan <nicolas.2p.debian@free.fr>
Reported-by: NRakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 c634263d
......@@ -3375,7 +3375,7 @@ static const struct file_operations bond_info_fops = {
.release = seq_release,
};
static int bond_create_proc_entry(struct bonding *bond)
static void bond_create_proc_entry(struct bonding *bond)
{
struct net_device *bond_dev = bond->dev;
......@@ -3390,8 +3390,6 @@ static int bond_create_proc_entry(struct bonding *bond)
else
memcpy(bond->proc_file_name, bond_dev->name, IFNAMSIZ);
}
return 0;
}
static void bond_remove_proc_entry(struct bonding *bond)
......@@ -3430,7 +3428,7 @@ static void bond_destroy_proc_dir(void)
#else /* !CONFIG_PROC_FS */
static int bond_create_proc_entry(struct bonding *bond)
static void bond_create_proc_entry(struct bonding *bond)
{
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册