提交 3382a622 编写于 作者: A Andrew Donnellan 提交者: Michael Ellerman

cxl: Fix coccinelle warnings

Fix the following coccinelle warnings:

  drivers/misc/cxl/debugfs.c:46:0-23: WARNING: fops_io_x64 should be
      defined with DEFINE_DEBUGFS_ATTRIBUTE
  drivers/misc/cxl/guest.c:890:5-26: WARNING: Comparison to bool
  drivers/misc/cxl/irq.c:107:3-23: WARNING: Assignment of bool to 0/1
  drivers/misc/cxl/native.c:57:2-3: Unneeded semicolon
  drivers/misc/cxl/native.c:170:2-3: Unneeded semicolon
Signed-off-by: NAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: NFrederic Barrat <fbarrat@linux.vnet.ibm.com>
Reviewed-by: NMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Acked-by: NIan Munsie <imunsie@au1.ibm.com>
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
上级 902e06eb
...@@ -43,12 +43,14 @@ static int debugfs_io_u64_set(void *data, u64 val) ...@@ -43,12 +43,14 @@ static int debugfs_io_u64_set(void *data, u64 val)
out_be64((u64 __iomem *)data, val); out_be64((u64 __iomem *)data, val);
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(fops_io_x64, debugfs_io_u64_get, debugfs_io_u64_set, "0x%016llx\n"); DEFINE_DEBUGFS_ATTRIBUTE(fops_io_x64, debugfs_io_u64_get, debugfs_io_u64_set,
"0x%016llx\n");
static struct dentry *debugfs_create_io_x64(const char *name, umode_t mode, static struct dentry *debugfs_create_io_x64(const char *name, umode_t mode,
struct dentry *parent, u64 __iomem *value) struct dentry *parent, u64 __iomem *value)
{ {
return debugfs_create_file(name, mode, parent, (void __force *)value, &fops_io_x64); return debugfs_create_file_unsafe(name, mode, parent,
(void __force *)value, &fops_io_x64);
} }
void cxl_debugfs_add_adapter_psl_regs(struct cxl *adapter, struct dentry *dir) void cxl_debugfs_add_adapter_psl_regs(struct cxl *adapter, struct dentry *dir)
......
...@@ -887,7 +887,7 @@ static void afu_handle_errstate(struct work_struct *work) ...@@ -887,7 +887,7 @@ static void afu_handle_errstate(struct work_struct *work)
afu_guest->previous_state == H_STATE_PERM_UNAVAILABLE) afu_guest->previous_state == H_STATE_PERM_UNAVAILABLE)
return; return;
if (afu_guest->handle_err == true) if (afu_guest->handle_err)
schedule_delayed_work(&afu_guest->work_err, schedule_delayed_work(&afu_guest->work_err,
msecs_to_jiffies(3000)); msecs_to_jiffies(3000));
} }
......
...@@ -104,7 +104,7 @@ irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_i ...@@ -104,7 +104,7 @@ irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_i
} else { } else {
spin_lock(&ctx->lock); spin_lock(&ctx->lock);
ctx->afu_err = irq_info->afu_err; ctx->afu_err = irq_info->afu_err;
ctx->pending_afu_err = 1; ctx->pending_afu_err = true;
spin_unlock(&ctx->lock); spin_unlock(&ctx->lock);
wake_up_all(&ctx->wq); wake_up_all(&ctx->wq);
......
...@@ -54,7 +54,7 @@ static int afu_control(struct cxl_afu *afu, u64 command, u64 clear, ...@@ -54,7 +54,7 @@ static int afu_control(struct cxl_afu *afu, u64 command, u64 clear,
AFU_Cntl | command); AFU_Cntl | command);
cpu_relax(); cpu_relax();
AFU_Cntl = cxl_p2n_read(afu, CXL_AFU_Cntl_An); AFU_Cntl = cxl_p2n_read(afu, CXL_AFU_Cntl_An);
}; }
if (AFU_Cntl & CXL_AFU_Cntl_An_RA) { if (AFU_Cntl & CXL_AFU_Cntl_An_RA) {
/* /*
...@@ -167,7 +167,7 @@ int cxl_psl_purge(struct cxl_afu *afu) ...@@ -167,7 +167,7 @@ int cxl_psl_purge(struct cxl_afu *afu)
cpu_relax(); cpu_relax();
} }
PSL_CNTL = cxl_p1n_read(afu, CXL_PSL_SCNTL_An); PSL_CNTL = cxl_p1n_read(afu, CXL_PSL_SCNTL_An);
}; }
end = local_clock(); end = local_clock();
pr_devel("PSL purged in %lld ns\n", end - start); pr_devel("PSL purged in %lld ns\n", end - start);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册