提交 2ed37f6c 编写于 作者: M Markus Elfring 提交者: Nicholas Bellinger

target: Deletion of unnecessary checks before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NNicholas Bellinger <nab@linux-iscsi.org>
上级 e7b7af6e
......@@ -26,8 +26,7 @@ struct iscsit_transport *iscsit_get_transport(int type)
void iscsit_put_transport(struct iscsit_transport *t)
{
if (t->owner)
module_put(t->owner);
module_put(t->owner);
}
int iscsit_register_transport(struct iscsit_transport *t)
......
......@@ -137,8 +137,7 @@ core_alloc_hba(const char *plugin_name, u32 plugin_dep_id, u32 hba_flags)
return hba;
out_module_put:
if (hba->transport->owner)
module_put(hba->transport->owner);
module_put(hba->transport->owner);
hba->transport = NULL;
out_free_hba:
kfree(hba);
......@@ -159,8 +158,7 @@ core_delete_hba(struct se_hba *hba)
pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target"
" Core\n", hba->hba_id);
if (hba->transport->owner)
module_put(hba->transport->owner);
module_put(hba->transport->owner);
hba->transport = NULL;
kfree(hba);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册