提交 242f8bfe 编写于 作者: D David S. Miller

pkt_sched: Make qdisc->gso_skb a list.

The idea is that we can use this to get rid of
->requeue().
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 3d09274c
...@@ -52,7 +52,7 @@ struct Qdisc ...@@ -52,7 +52,7 @@ struct Qdisc
u32 parent; u32 parent;
atomic_t refcnt; atomic_t refcnt;
unsigned long state; unsigned long state;
struct sk_buff *gso_skb; struct sk_buff_head requeue;
struct sk_buff_head q; struct sk_buff_head q;
struct netdev_queue *dev_queue; struct netdev_queue *dev_queue;
struct Qdisc *next_sched; struct Qdisc *next_sched;
......
...@@ -45,7 +45,7 @@ static inline int qdisc_qlen(struct Qdisc *q) ...@@ -45,7 +45,7 @@ static inline int qdisc_qlen(struct Qdisc *q)
static inline int dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q) static inline int dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q)
{ {
if (unlikely(skb->next)) if (unlikely(skb->next))
q->gso_skb = skb; __skb_queue_head(&q->requeue, skb);
else else
q->ops->requeue(skb, q); q->ops->requeue(skb, q);
...@@ -57,9 +57,8 @@ static inline struct sk_buff *dequeue_skb(struct Qdisc *q) ...@@ -57,9 +57,8 @@ static inline struct sk_buff *dequeue_skb(struct Qdisc *q)
{ {
struct sk_buff *skb; struct sk_buff *skb;
if ((skb = q->gso_skb)) skb = __skb_dequeue(&q->requeue);
q->gso_skb = NULL; if (!skb)
else
skb = q->dequeue(q); skb = q->dequeue(q);
return skb; return skb;
...@@ -327,6 +326,7 @@ struct Qdisc noop_qdisc = { ...@@ -327,6 +326,7 @@ struct Qdisc noop_qdisc = {
.flags = TCQ_F_BUILTIN, .flags = TCQ_F_BUILTIN,
.ops = &noop_qdisc_ops, .ops = &noop_qdisc_ops,
.list = LIST_HEAD_INIT(noop_qdisc.list), .list = LIST_HEAD_INIT(noop_qdisc.list),
.requeue.lock = __SPIN_LOCK_UNLOCKED(noop_qdisc.q.lock),
.q.lock = __SPIN_LOCK_UNLOCKED(noop_qdisc.q.lock), .q.lock = __SPIN_LOCK_UNLOCKED(noop_qdisc.q.lock),
.dev_queue = &noop_netdev_queue, .dev_queue = &noop_netdev_queue,
}; };
...@@ -352,6 +352,7 @@ static struct Qdisc noqueue_qdisc = { ...@@ -352,6 +352,7 @@ static struct Qdisc noqueue_qdisc = {
.flags = TCQ_F_BUILTIN, .flags = TCQ_F_BUILTIN,
.ops = &noqueue_qdisc_ops, .ops = &noqueue_qdisc_ops,
.list = LIST_HEAD_INIT(noqueue_qdisc.list), .list = LIST_HEAD_INIT(noqueue_qdisc.list),
.requeue.lock = __SPIN_LOCK_UNLOCKED(noqueue_qdisc.q.lock),
.q.lock = __SPIN_LOCK_UNLOCKED(noqueue_qdisc.q.lock), .q.lock = __SPIN_LOCK_UNLOCKED(noqueue_qdisc.q.lock),
.dev_queue = &noqueue_netdev_queue, .dev_queue = &noqueue_netdev_queue,
}; };
...@@ -472,6 +473,7 @@ struct Qdisc *qdisc_alloc(struct netdev_queue *dev_queue, ...@@ -472,6 +473,7 @@ struct Qdisc *qdisc_alloc(struct netdev_queue *dev_queue,
sch->padded = (char *) sch - (char *) p; sch->padded = (char *) sch - (char *) p;
INIT_LIST_HEAD(&sch->list); INIT_LIST_HEAD(&sch->list);
skb_queue_head_init(&sch->requeue);
skb_queue_head_init(&sch->q); skb_queue_head_init(&sch->q);
sch->ops = ops; sch->ops = ops;
sch->enqueue = ops->enqueue; sch->enqueue = ops->enqueue;
...@@ -539,7 +541,7 @@ void qdisc_destroy(struct Qdisc *qdisc) ...@@ -539,7 +541,7 @@ void qdisc_destroy(struct Qdisc *qdisc)
module_put(ops->owner); module_put(ops->owner);
dev_put(qdisc_dev(qdisc)); dev_put(qdisc_dev(qdisc));
kfree_skb(qdisc->gso_skb); __skb_queue_purge(&qdisc->requeue);
kfree((char *) qdisc - qdisc->padded); kfree((char *) qdisc - qdisc->padded);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册