提交 1915a718 编写于 作者: K Krzysztof Kozlowski 提交者: Sebastian Reichel

compal-laptop: Check return value of power_supply_register

The return value of power_supply_register() call was not checked and
even on error probe() function returned 0. If registering failed then
during unbind the driver tried to unregister power supply which was not
actually registered.

This could lead to memory corruption because power_supply_unregister()
unconditionally cleans up given power supply.

Fix this by checking return status of power_supply_register() call. In
case of failure, clean up sysfs entries and fail the probe.
Signed-off-by: NKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 9be0fcb5 ("compal-laptop: add JHL90, battery & hwmon interface")
Cc: <stable@vger.kernel.org>
Signed-off-by: NSebastian Reichel <sre@kernel.org>
上级 ad774702
...@@ -1036,7 +1036,9 @@ static int compal_probe(struct platform_device *pdev) ...@@ -1036,7 +1036,9 @@ static int compal_probe(struct platform_device *pdev)
/* Power supply */ /* Power supply */
initialize_power_supply_data(data); initialize_power_supply_data(data);
power_supply_register(&compal_device->dev, &data->psy); err = power_supply_register(&compal_device->dev, &data->psy);
if (err < 0)
goto remove;
platform_set_drvdata(pdev, data); platform_set_drvdata(pdev, data);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册