提交 187cd44e 编写于 作者: A Al Viro

sparc: missing checks of __get_user()/__put_user() return values

Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
上级 9a078802
...@@ -215,8 +215,9 @@ void do_sigreturn32(struct pt_regs *regs) ...@@ -215,8 +215,9 @@ void do_sigreturn32(struct pt_regs *regs)
(((unsigned long) sf) & 3)) (((unsigned long) sf) & 3))
goto segv; goto segv;
get_user(pc, &sf->info.si_regs.pc); if (get_user(pc, &sf->info.si_regs.pc) ||
__get_user(npc, &sf->info.si_regs.npc); __get_user(npc, &sf->info.si_regs.npc))
goto segv;
if ((pc | npc) & 3) if ((pc | npc) & 3)
goto segv; goto segv;
...@@ -305,8 +306,9 @@ asmlinkage void do_rt_sigreturn32(struct pt_regs *regs) ...@@ -305,8 +306,9 @@ asmlinkage void do_rt_sigreturn32(struct pt_regs *regs)
(((unsigned long) sf) & 3)) (((unsigned long) sf) & 3))
goto segv; goto segv;
get_user(pc, &sf->regs.pc); if (get_user(pc, &sf->regs.pc) ||
__get_user(npc, &sf->regs.npc); __get_user(npc, &sf->regs.npc))
goto segv;
if ((pc | npc) & 3) if ((pc | npc) & 3)
goto segv; goto segv;
......
...@@ -184,10 +184,10 @@ sparc_sigaction (int sig, const struct old_sigaction __user *act, ...@@ -184,10 +184,10 @@ sparc_sigaction (int sig, const struct old_sigaction __user *act,
if (!access_ok(VERIFY_READ, act, sizeof(*act)) || if (!access_ok(VERIFY_READ, act, sizeof(*act)) ||
__get_user(new_ka.sa.sa_handler, &act->sa_handler) || __get_user(new_ka.sa.sa_handler, &act->sa_handler) ||
__get_user(new_ka.sa.sa_restorer, &act->sa_restorer)) __get_user(new_ka.sa.sa_restorer, &act->sa_restorer) ||
__get_user(new_ka.sa.sa_flags, &act->sa_flags) ||
__get_user(mask, &act->sa_mask))
return -EFAULT; return -EFAULT;
__get_user(new_ka.sa.sa_flags, &act->sa_flags);
__get_user(mask, &act->sa_mask);
siginitset(&new_ka.sa.sa_mask, mask); siginitset(&new_ka.sa.sa_mask, mask);
new_ka.ka_restorer = NULL; new_ka.ka_restorer = NULL;
} }
...@@ -202,10 +202,10 @@ sparc_sigaction (int sig, const struct old_sigaction __user *act, ...@@ -202,10 +202,10 @@ sparc_sigaction (int sig, const struct old_sigaction __user *act,
*/ */
if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)) || if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)) ||
__put_user(old_ka.sa.sa_handler, &oact->sa_handler) || __put_user(old_ka.sa.sa_handler, &oact->sa_handler) ||
__put_user(old_ka.sa.sa_restorer, &oact->sa_restorer)) __put_user(old_ka.sa.sa_restorer, &oact->sa_restorer) ||
__put_user(old_ka.sa.sa_flags, &oact->sa_flags) ||
__put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask))
return -EFAULT; return -EFAULT;
__put_user(old_ka.sa.sa_flags, &oact->sa_flags);
__put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask);
} }
return ret; return ret;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册