提交 17a5d018 编写于 作者: C Colin Ian King 提交者: Greg Kroah-Hartman

drm/amdgpu/powerplay: fix missing break in switch statements

[ Upstream commit 14b284832e7dea6f54f0adfd7bed105548b94e57 ]

There are several switch statements that are missing break statements.
Add missing breaks to handle any fall-throughs corner cases.

Detected by CoverityScan, CID#1457175 ("Missing break in switch")

Fixes: 18aafc59 ("drm/amd/powerplay: implement fw related smu interface for iceland.")
Acked-by: NHuang Rui <ray.huang@amd.com>
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 05dff1e2
...@@ -2268,11 +2268,13 @@ static uint32_t ci_get_offsetof(uint32_t type, uint32_t member) ...@@ -2268,11 +2268,13 @@ static uint32_t ci_get_offsetof(uint32_t type, uint32_t member)
case DRAM_LOG_BUFF_SIZE: case DRAM_LOG_BUFF_SIZE:
return offsetof(SMU7_SoftRegisters, DRAM_LOG_BUFF_SIZE); return offsetof(SMU7_SoftRegisters, DRAM_LOG_BUFF_SIZE);
} }
break;
case SMU_Discrete_DpmTable: case SMU_Discrete_DpmTable:
switch (member) { switch (member) {
case LowSclkInterruptThreshold: case LowSclkInterruptThreshold:
return offsetof(SMU7_Discrete_DpmTable, LowSclkInterruptT); return offsetof(SMU7_Discrete_DpmTable, LowSclkInterruptT);
} }
break;
} }
pr_debug("can't get the offset of type %x member %x\n", type, member); pr_debug("can't get the offset of type %x member %x\n", type, member);
return 0; return 0;
......
...@@ -2330,6 +2330,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member) ...@@ -2330,6 +2330,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
case DRAM_LOG_BUFF_SIZE: case DRAM_LOG_BUFF_SIZE:
return offsetof(SMU73_SoftRegisters, DRAM_LOG_BUFF_SIZE); return offsetof(SMU73_SoftRegisters, DRAM_LOG_BUFF_SIZE);
} }
break;
case SMU_Discrete_DpmTable: case SMU_Discrete_DpmTable:
switch (member) { switch (member) {
case UvdBootLevel: case UvdBootLevel:
...@@ -2339,6 +2340,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member) ...@@ -2339,6 +2340,7 @@ static uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
case LowSclkInterruptThreshold: case LowSclkInterruptThreshold:
return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold); return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
} }
break;
} }
pr_warn("can't get the offset of type %x member %x\n", type, member); pr_warn("can't get the offset of type %x member %x\n", type, member);
return 0; return 0;
......
...@@ -2236,11 +2236,13 @@ static uint32_t iceland_get_offsetof(uint32_t type, uint32_t member) ...@@ -2236,11 +2236,13 @@ static uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
case DRAM_LOG_BUFF_SIZE: case DRAM_LOG_BUFF_SIZE:
return offsetof(SMU71_SoftRegisters, DRAM_LOG_BUFF_SIZE); return offsetof(SMU71_SoftRegisters, DRAM_LOG_BUFF_SIZE);
} }
break;
case SMU_Discrete_DpmTable: case SMU_Discrete_DpmTable:
switch (member) { switch (member) {
case LowSclkInterruptThreshold: case LowSclkInterruptThreshold:
return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold); return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
} }
break;
} }
pr_warn("can't get the offset of type %x member %x\n", type, member); pr_warn("can't get the offset of type %x member %x\n", type, member);
return 0; return 0;
......
...@@ -2618,6 +2618,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member) ...@@ -2618,6 +2618,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
case DRAM_LOG_BUFF_SIZE: case DRAM_LOG_BUFF_SIZE:
return offsetof(SMU72_SoftRegisters, DRAM_LOG_BUFF_SIZE); return offsetof(SMU72_SoftRegisters, DRAM_LOG_BUFF_SIZE);
} }
break;
case SMU_Discrete_DpmTable: case SMU_Discrete_DpmTable:
switch (member) { switch (member) {
case UvdBootLevel: case UvdBootLevel:
...@@ -2627,6 +2628,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member) ...@@ -2627,6 +2628,7 @@ static uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
case LowSclkInterruptThreshold: case LowSclkInterruptThreshold:
return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold); return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
} }
break;
} }
pr_warn("can't get the offset of type %x member %x\n", type, member); pr_warn("can't get the offset of type %x member %x\n", type, member);
return 0; return 0;
......
...@@ -2184,6 +2184,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member) ...@@ -2184,6 +2184,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member)
case DRAM_LOG_BUFF_SIZE: case DRAM_LOG_BUFF_SIZE:
return offsetof(SMU75_SoftRegisters, DRAM_LOG_BUFF_SIZE); return offsetof(SMU75_SoftRegisters, DRAM_LOG_BUFF_SIZE);
} }
break;
case SMU_Discrete_DpmTable: case SMU_Discrete_DpmTable:
switch (member) { switch (member) {
case UvdBootLevel: case UvdBootLevel:
...@@ -2193,6 +2194,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member) ...@@ -2193,6 +2194,7 @@ static uint32_t vegam_get_offsetof(uint32_t type, uint32_t member)
case LowSclkInterruptThreshold: case LowSclkInterruptThreshold:
return offsetof(SMU75_Discrete_DpmTable, LowSclkInterruptThreshold); return offsetof(SMU75_Discrete_DpmTable, LowSclkInterruptThreshold);
} }
break;
} }
pr_warn("can't get the offset of type %x member %x\n", type, member); pr_warn("can't get the offset of type %x member %x\n", type, member);
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册