提交 13101602 编写于 作者: G Geert Uytterhoeven 提交者: David S. Miller

openvswitch: Add missing initialization in validate_and_copy_set_tun()

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than
OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
validate_and_copy_set_tun() may return an undefined value instead of a
zero success indicator. Initialize err to zero to fix this.

Fixes: 1dd144cf ("openvswitch: Support VXLAN Group Policy extension")
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: NThomas Graf <tgraf@suug.ch>
Acked-by: NPravin B Shelar <pshelar@nicira.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 b35725a2
...@@ -1746,7 +1746,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr, ...@@ -1746,7 +1746,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr,
struct sw_flow_key key; struct sw_flow_key key;
struct ovs_tunnel_info *tun_info; struct ovs_tunnel_info *tun_info;
struct nlattr *a; struct nlattr *a;
int err, start, opts_type; int err = 0, start, opts_type;
ovs_match_init(&match, &key, NULL); ovs_match_init(&match, &key, NULL);
opts_type = ipv4_tun_from_nlattr(nla_data(attr), &match, false, log); opts_type = ipv4_tun_from_nlattr(nla_data(attr), &match, false, log);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册