• G
    spi: Make master->handle_err() callback optional to avoid crashes · ff61eb42
    Geert Uytterhoeven 提交于
    If a driver doesn't implement the master->handle_err() callback and an
    SPI transfer fails, the kernel will crash with a NULL pointer
    dereference:
    
        Unable to handle kernel NULL pointer dereference at virtual address 00000000
        pgd = c0003000
        [00000000] *pgd=80000040004003, *pmd=00000000
        Internal error: Oops: 80000206 [#1] SMP ARM
        Modules linked in:
        CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.0.0-rc7-koelsch-05861-g1fc9fdd4add4f783 #1046
        Hardware name: Generic R8A7791 (Flattened Device Tree)
        task: eec359c0 ti: eec54000 task.ti: eec54000
        PC is at 0x0
        LR is at spi_transfer_one_message+0x1cc/0x1f0
    
    Make the master->handle_err() callback optional to avoid the crash.
    
    Also fix a spelling mistake in the callback documentation while we're at
    it.
    
    Fixes: b716c4ff ("spi: introduce master->handle_err() callback")
    Signed-off-by: NGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: NMark Brown <broonie@kernel.org>
    ff61eb42
spi.c 65.1 KB