• J
    ext4: Don't clear SGID when inheriting ACLs · a3bb2d55
    Jan Kara 提交于
    When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit
    set, DIR1 is expected to have SGID bit set (and owning group equal to
    the owning group of 'DIR0'). However when 'DIR0' also has some default
    ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on
    'DIR1' to get cleared if user is not member of the owning group.
    
    Fix the problem by moving posix_acl_update_mode() out of
    __ext4_set_acl() into ext4_set_acl(). That way the function will not be
    called when inheriting ACLs which is what we want as it prevents SGID
    bit clearing and the mode has been properly set by posix_acl_create()
    anyway.
    
    Fixes: 07393101
    CC: stable@vger.kernel.org
    Signed-off-by: NTheodore Ts'o <tytso@mit.edu>
    Signed-off-by: NJan Kara <jack@suse.cz>
    Reviewed-by: NAndreas Gruenbacher <agruenba@redhat.com>
    a3bb2d55
acl.c 6.4 KB