• S
    batman-adv: Prevent duplicated nc_node entry · fa122fec
    Sven Eckelmann 提交于
    The function batadv_nc_get_nc_node is responsible for adding new nc_nodes
    to the in_coding_list and out_coding_list. It first checks whether the
    entry already is in the list or not. If it is, then the creation of a new
    entry is aborted.
    
    But the lock for the list is only held when the list is really modified.
    This could lead to duplicated entries because another context could create
    an entry with the same key between the check and the list manipulation.
    
    The check and the manipulation of the list must therefore be in the same
    locked code section.
    
    Fixes: d56b1705 ("batman-adv: network coding - detect coding nodes and remove these after timeout")
    Signed-off-by: NSven Eckelmann <sven@narfation.org>
    Acked-by: NMarek Lindner <mareklindner@neomailbox.ch>
    Signed-off-by: NSimon Wunderlich <sw@simonwunderlich.de>
    fa122fec
network-coding.c 58.8 KB