• E
    crypto: sha512-mb - initialize pending lengths correctly · eff84b37
    Eric Biggers 提交于
    The SHA-512 multibuffer code keeps track of the number of blocks pending
    in each lane.  The minimum of these values is used to identify the next
    lane that will be completed.  Unused lanes are set to a large number
    (0xFFFFFFFF) so that they don't affect this calculation.
    
    However, it was forgotten to set the lengths to this value in the
    initial state, where all lanes are unused.  As a result it was possible
    for sha512_mb_mgr_get_comp_job_avx2() to select an unused lane, causing
    a NULL pointer dereference.  Specifically this could happen in the case
    where ->update() was passed fewer than SHA512_BLOCK_SIZE bytes of data,
    so it then called sha_complete_job() without having actually submitted
    any blocks to the multi-buffer code.  This hit a NULL pointer
    dereference if another task happened to have submitted blocks
    concurrently to the same CPU and the flush timer had not yet expired.
    
    Fix this by initializing sha512_mb_mgr->lens correctly.
    
    As usual, this bug was found by syzkaller.
    
    Fixes: 45691e2d ("crypto: sha512-mb - submit/flush routines for AVX2")
    Reported-by: Nsyzbot <syzkaller@googlegroups.com>
    Cc: <stable@vger.kernel.org> # v4.8+
    Signed-off-by: NEric Biggers <ebiggers@google.com>
    Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
    eff84b37
sha512_mb_mgr_init_avx2.c 2.7 KB