• J
    objtool: Prevent GCC from merging annotate_unreachable(), take 2 · ec1e1b61
    Josh Poimboeuf 提交于
    This fixes the following warning with GCC 4.6:
    
      mm/migrate.o: warning: objtool: migrate_misplaced_transhuge_page()+0x71: unreachable instruction
    
    The problem is that the compiler merged identical annotate_unreachable()
    inline asm blocks, resulting in a missing 'unreachable' annotation.
    
    This problem happened before, and was partially fixed with:
    
      3d1e2360 ("objtool: Prevent GCC from merging annotate_unreachable()")
    
    That commit tried to ensure that each instance of the
    annotate_unreachable() inline asm statement has a unique label.  It used
    the __LINE__ macro to generate the label number.  However, even the line
    number isn't necessarily unique when used in an inline function with
    multiple callers (in this case, __alloc_pages_node()'s use of
    VM_BUG_ON).
    Reported-by: Nkbuild test robot <fengguang.wu@intel.com>
    Signed-off-by: NJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: kbuild-all@01.org
    Cc: tipbuild@zytor.com
    Fixes: 3d1e2360 ("objtool: Prevent GCC from merging annotate_unreachable()")
    Link: http://lkml.kernel.org/r/20171103221941.cajpwszir7ujxyc4@trebleSigned-off-by: NIngo Molnar <mingo@kernel.org>
    ec1e1b61
compiler.h 18.4 KB