• D
    rxrpc: Delay the resend timer to allow for nsec->jiffies conv error · df0562a7
    David Howells 提交于
    When determining the resend timer value, we have a value in nsec but the
    timer is in jiffies which may be a million or more times more coarse.
    nsecs_to_jiffies() rounds down - which means that the resend timeout
    expressed as jiffies is very likely earlier than the one expressed as
    nanoseconds from which it was derived.
    
    The problem is that rxrpc_resend() gets triggered by the timer, but can't
    then find anything to resend yet.  It sets the timer again - but gets
    kicked off immediately again and again until the nanosecond-based expiry
    time is reached and we actually retransmit.
    
    Fix this by adding 1 to the jiffies-based resend_at value to counteract the
    rounding and make sure that the timer happens after the nanosecond-based
    expiry is passed.
    
    Alternatives would be to adjust the timestamp on the packets to align
    with the jiffie scale or to switch back to using jiffie-timestamps.
    Signed-off-by: NDavid Howells <dhowells@redhat.com>
    df0562a7
call_event.c 8.7 KB