• W
    KVM: Fix steal clock warp during guest CPU hotplug · 2348140d
    Wanpeng Li 提交于
    Sometimes, after CPU hotplug you can observe a spike in stolen time
    (100%) followed by the CPU being marked as 100% idle when it's actually
    busy with a CPU hog task.  The trace looks like the following:
    
     cpuhp/1-12    [001] d.h1   167.461657: account_process_tick: steal = 1291385514, prev_steal_time = 0
     cpuhp/1-12    [001] d.h1   167.461659: account_process_tick: steal_jiffies = 1291
      <idle>-0     [001] d.h1   167.462663: account_process_tick: steal = 18732255, prev_steal_time = 1291000000
      <idle>-0     [001] d.h1   167.462664: account_process_tick: steal_jiffies = 18446744072437
    
    The sudden decrease of "steal" causes steal_jiffies to underflow.
    The root cause is kvm_steal_time being reset to 0 after hot-plugging
    back in a CPU.  Instead, the preexisting value can be used, which is
    what the core scheduler code expects.
    
    John Stultz also reported a similar issue after guest S3.
    Suggested-by: NPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: NWanpeng Li <wanpeng.li@hotmail.com>
    Signed-off-by: NPeter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: NPaolo Bonzini <pbonzini@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: John Stultz <john.stultz@linaro.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Radim Krčmář <rkrcmar@redhat.com>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/1465813966-3116-2-git-send-email-wanpeng.li@hotmail.comSigned-off-by: NIngo Molnar <mingo@kernel.org>
    2348140d
kvm.c 19.7 KB