• M
    panic, vt: do not force oops output when panic_timeout < 0 · c958474b
    Mandeep Singh Baines 提交于
    Don't force output if you intend to reboot immediately.
    
    In this patch, I'm disabling the functionality enabled by
    vc->vc_panic_force_write if panic_timeout < 0 (i.e.  no timeout).
    vc_panic_force_write is only enabled for fb video consoles if the
    FBINFO_CAN_FORCE_OUTPUT flag is set.
    
    For our application, we're using ram_oops to preserved the panic in
    memory.  We want to reliably, and as fast as possible, machine_restart.
    The vc_panic_force_write flag results in a bunch of graphics driver code
    to be invoked which slows down restart and decreases reliability.  Since
    we're already storing the panic in RAM and are going to reboot
    immediately, there is no benefit in mode switching back to the vc in
    order to display the panic output.  The log buffer will get flushed by
    the console_unblank() call so remote management consoles should see all
    output.
    Signed-off-by: NMandeep Singh Baines <msb@chromium.org>
    Cc: Huang Ying <ying.huang@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Olaf Hering <olaf@aepfle.de>
    Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: Dave Airlie <airlied@gmail.com>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Acked-by: NAlan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    c958474b
vt_kern.h 4.9 KB