• J
    io_uring: fix -ENOENT issue with linked timer with short timeout · c564c48d
    Jens Axboe 提交于
    commit 76a46e066e2d93bd333599d1c84c605c2c4cc909 upstream.
    
    If you prep a read (for example) that needs to get punted to async
    context with a timer, if the timeout is sufficiently short, the timer
    request will get completed with -ENOENT as it could not find the read.
    
    The issue is that we prep and start the timer before we start the read.
    Hence the timer can trigger before the read is even started, and the end
    result is then that the timer completes with -ENOENT, while the read
    starts instead of being cancelled by the timer.
    
    Fix this by splitting the linked timer into two parts:
    
    1) Prep and validate the linked timer
    2) Start timer
    
    The read is then started between steps 1 and 2, so we know that the
    timer will always have a consistent view of the read request state.
    Reported-by: NHrvoje Zeba <zeba.hrvoje@gmail.com>
    Signed-off-by: NJens Axboe <axboe@kernel.dk>
    Signed-off-by: NJoseph Qi <joseph.qi@linux.alibaba.com>
    Reviewed-by: NXiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
    c564c48d
io_uring.c 113.7 KB