• B
    scsi: Fix a bdi reregistration race · bf2cf3ba
    Bart Van Assche 提交于
    Unregister and reregister BDI devices in the proper order. This patch
    avoids that the following kernel warning can get triggered:
    
    WARNING: CPU: 7 PID: 203 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80()
    sysfs: cannot create duplicate filename '/devices/virtual/bdi/8:32'
    Workqueue: events_unbound async_run_entry_fn
    Call Trace:
    [<ffffffff814ff5a4>] dump_stack+0x4c/0x65
    [<ffffffff810746ba>] warn_slowpath_common+0x8a/0xc0
    [<ffffffff81074736>] warn_slowpath_fmt+0x46/0x50
    [<ffffffff81237ca8>] sysfs_warn_dup+0x68/0x80
    [<ffffffff81237d8e>] sysfs_create_dir_ns+0x7e/0x90
    [<ffffffff81291f58>] kobject_add_internal+0xa8/0x320
    [<ffffffff812923a0>] kobject_add+0x60/0xb0
    [<ffffffff8138c937>] device_add+0x107/0x5e0
    [<ffffffff8138d018>] device_create_groups_vargs+0xd8/0x100
    [<ffffffff8138d05c>] device_create_vargs+0x1c/0x20
    [<ffffffff8117f233>] bdi_register+0x63/0x2a0
    [<ffffffff8117f497>] bdi_register_dev+0x27/0x30
    [<ffffffff81281549>] add_disk+0x1a9/0x4e0
    [<ffffffffa00c5739>] sd_probe_async+0x119/0x1d0 [sd_mod]
    [<ffffffff8109a81a>] async_run_entry_fn+0x4a/0x140
    [<ffffffff81091078>] process_one_work+0x1d8/0x7c0
    [<ffffffff81091774>] worker_thread+0x114/0x460
    [<ffffffff81097878>] kthread+0xf8/0x110
    [<ffffffff8150801f>] ret_from_fork+0x3f/0x70
    
    See also patch "block: destroy bdi before blockdev is unregistered"
    (commit ID 6cd18e71).
    Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
    Reviewed-by: NHannes Reinecke <hare@suse.de>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
    bf2cf3ba
scsi_sysfs.c 32.9 KB