• S
    ftrace: Have control op function callback only trace when RCU is watching · b5aa3a47
    Steven Rostedt (Red Hat) 提交于
    Dave Jones reported that trinity would be able to trigger the following
    back trace:
    
     ===============================
     [ INFO: suspicious RCU usage. ]
     3.10.0-rc2+ #38 Not tainted
     -------------------------------
     include/linux/rcupdate.h:771 rcu_read_lock() used illegally while idle!
     other info that might help us debug this:
    
     RCU used illegally from idle CPU!  rcu_scheduler_active = 1, debug_locks = 0
     RCU used illegally from extended quiescent state!
     1 lock held by trinity-child1/18786:
      #0:  (rcu_read_lock){.+.+..}, at: [<ffffffff8113dd48>] __perf_event_overflow+0x108/0x310
     stack backtrace:
     CPU: 3 PID: 18786 Comm: trinity-child1 Not tainted 3.10.0-rc2+ #38
      0000000000000000 ffff88020767bac8 ffffffff816e2f6b ffff88020767baf8
      ffffffff810b5897 ffff88021de92520 0000000000000000 ffff88020767bbf8
      0000000000000000 ffff88020767bb78 ffffffff8113ded4 ffffffff8113dd48
     Call Trace:
      [<ffffffff816e2f6b>] dump_stack+0x19/0x1b
      [<ffffffff810b5897>] lockdep_rcu_suspicious+0xe7/0x120
      [<ffffffff8113ded4>] __perf_event_overflow+0x294/0x310
      [<ffffffff8113dd48>] ? __perf_event_overflow+0x108/0x310
      [<ffffffff81309289>] ? __const_udelay+0x29/0x30
      [<ffffffff81076054>] ? __rcu_read_unlock+0x54/0xa0
      [<ffffffff816f4000>] ? ftrace_call+0x5/0x2f
      [<ffffffff8113dfa1>] perf_swevent_overflow+0x51/0xe0
      [<ffffffff8113e08f>] perf_swevent_event+0x5f/0x90
      [<ffffffff8113e1c9>] perf_tp_event+0x109/0x4f0
      [<ffffffff8113e36f>] ? perf_tp_event+0x2af/0x4f0
      [<ffffffff81074630>] ? __rcu_read_lock+0x20/0x20
      [<ffffffff8112d79f>] perf_ftrace_function_call+0xbf/0xd0
      [<ffffffff8110e1e1>] ? ftrace_ops_control_func+0x181/0x210
      [<ffffffff81074630>] ? __rcu_read_lock+0x20/0x20
      [<ffffffff81100cae>] ? rcu_eqs_enter_common+0x5e/0x470
      [<ffffffff8110e1e1>] ftrace_ops_control_func+0x181/0x210
      [<ffffffff816f4000>] ftrace_call+0x5/0x2f
      [<ffffffff8110e229>] ? ftrace_ops_control_func+0x1c9/0x210
      [<ffffffff816f4000>] ? ftrace_call+0x5/0x2f
      [<ffffffff81074635>] ? debug_lockdep_rcu_enabled+0x5/0x40
      [<ffffffff81074635>] ? debug_lockdep_rcu_enabled+0x5/0x40
      [<ffffffff81100cae>] ? rcu_eqs_enter_common+0x5e/0x470
      [<ffffffff8110112a>] rcu_eqs_enter+0x6a/0xb0
      [<ffffffff81103673>] rcu_user_enter+0x13/0x20
      [<ffffffff8114541a>] user_enter+0x6a/0xd0
      [<ffffffff8100f6d8>] syscall_trace_leave+0x78/0x140
      [<ffffffff816f46af>] int_check_syscall_exit_work+0x34/0x3d
     ------------[ cut here ]------------
    
    Perf uses rcu_read_lock() but as the function tracer can trace functions
    even when RCU is not currently active, this makes the rcu_read_lock()
    used by perf ineffective.
    
    As perf is currently the only user of the ftrace_ops_control_func() and
    perf is also the only function callback that actively uses rcu_read_lock(),
    the quick fix is to prevent the ftrace_ops_control_func() from calling
    its callbacks if RCU is not active.
    
    With Paul's new "rcu_is_watching()" we can tell if RCU is active or not.
    Reported-by: NDave Jones <davej@redhat.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Signed-off-by: NSteven Rostedt <rostedt@goodmis.org>
    b5aa3a47
ftrace.c 113.4 KB