• J
    writeback: stop background/kupdate works from livelocking other works · aa373cf5
    Jan Kara 提交于
    Background writeback is easily livelockable in a loop in wb_writeback() by
    a process continuously re-dirtying pages (or continuously appending to a
    file).  This is in fact intended as the target of background writeback is
    to write dirty pages it can find as long as we are over
    dirty_background_threshold.
    
    But the above behavior gets inconvenient at times because no other work
    queued in the flusher thread's queue gets processed.  In particular, since
    e.g.  sync(1) relies on flusher thread to do all the IO for it, sync(1)
    can hang forever waiting for flusher thread to do the work.
    
    Generally, when a flusher thread has some work queued, someone submitted
    the work to achieve a goal more specific than what background writeback
    does.  Moreover by working on the specific work, we also reduce amount of
    dirty pages which is exactly the target of background writeout.  So it
    makes sense to give specific work a priority over a generic page cleaning.
    
    Thus we interrupt background writeback if there is some other work to do.
    We return to the background writeback after completing all the queued
    work.
    
    This may delay the writeback of expired inodes for a while, however the
    expired inodes will eventually be flushed to disk as long as the other
    works won't livelock.
    
    [fengguang.wu@intel.com: update comment]
    Signed-off-by: NJan Kara <jack@suse.cz>
    Signed-off-by: NWu Fengguang <fengguang.wu@intel.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Dave Chinner <david@fromorbit.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Jan Engelhardt <jengelh@medozas.de>
    Cc: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    aa373cf5
fs-writeback.c 33.6 KB