-
A rmb() is required to ensure that the CQE is not read before it is written by the adapter DMA. PCI ordering rules will make sure the other fields are written before the marker at the end of struct eth_fast_path_rx_cqe but without rmb() a weakly ordered processor can process stale data. Without the barrier we have observed various crashes including bnx2x_tpa_start being called on queues not stopped (resulting in message start of bin not in stop) and NULL pointer exceptions from bnx2x_rx_int. Signed-off-by: NMilton Miller <miltonm@us.ibm.com> Signed-off-by: NWen Xiong <wenxiong@linux.vnet.ibm.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
9aaae044