• R
    [PATCH] x86: Fix boot hang due to nmi watchdog init code · 92715e28
    Ravikiran G Thirumalai 提交于
    2.6.19  stopped booting (or booted based on build/config) on our x86_64
    systems due to a bug introduced in 2.6.19.  check_nmi_watchdog schedules an
    IPI on all cpus to  busy wait on a flag, but fails to set the busywait
    flag if NMI functionality is disabled.  This causes the secondary cpus
    to spin in an endless loop, causing the kernel bootup to hang.
    Depending upon the build, the  busywait flag got overwritten (stack variable)
    and caused  the kernel to bootup on certain builds.  Following patch fixes
    the bug by setting the busywait flag before returning from check_nmi_watchdog.
    I guess using a stack variable is not good here as the calling function could
    potentially return while the busy wait loop is still spinning on the flag.
    
    AK: I redid the patch significantly to be cleaner
    Signed-off-by: NRavikiran Thirumalai <kiran@scalex86.org>
    Signed-off-by: NShai Fultheim <shai@scalex86.org>
    Signed-off-by: NAndi Kleen <ak@suse.de>
    92715e28
nmi.c 23.9 KB