• S
    [SCSI] aacraid: do not set valid bit in sense information · 8e31e607
    Salyzyn, Mark 提交于
    Luben Tuikov [mailto:ltuikov@yahoo.com] sez:
    > Just as in your case and Tony's case, which I presume
    > uses the same RAID firmware vendor, it would've
    > probably been better if the RAID firmware vendor
    > fixed the firmware to not set the VALID bit if the
    > INFORMATION field is not valid.
    
    Point taken regarding the aacraid driver. Dropped the VALID bit, and
    then did some cleanup/simplification of the set_sense procedure and
    the associated parameters. Mike did some preliminary tests when the
    VALID bit was dropped before the 'Re: [PATCH] [SCSI] sd: make error
    handling more robust' patches came on the scene. The change in the
    SCSI subsystem does make this enclosed aacraid patch unnecessary, so
    this aacraid patch is merely post battle ground cleanup. If the
    simplification is an issue, repugnant, too much for a back-port to the
    stable trees or clouds the point, this patch could be happily
    distilled down to:
    
    diff -ru a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
    --- a/drivers/scsi/aacraid/aachba.c     2008-02-06 16:26:45.834938955 -0500
    +++ b/drivers/scsi/aacraid/aachba.c     2008-02-06 16:32:01.109035329 -0500
    @@ -865,7 +865,7 @@
                             u32 residue)
     {
    -        sense_buf[0] = 0xF0;    /* Sense data valid, err code 70h (current error) */
    +        sense_buf[0] = 0x70;    /* Sense data invalid, err code 70h (current error) */
             sense_buf[1] = 0;       /* Segment number, always zero */
    
             if (incorrect_length) {
    Signed-off-by: NMark Salyzyn <aacraid@adaptec.com>
    Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
    8e31e607
aachba.c 78.6 KB