• J
    buffer: set errors in mapping at the time that the error occurs · 87354e5d
    Jeff Layton 提交于
    I noticed on xfs that I could still sometimes get back an error on fsync
    on a fd that was opened after the error condition had been cleared.
    
    The problem is that the buffer code sets the write_io_error flag and
    then later checks that flag to set the error in the mapping. That flag
    perisists for quite a while however. If the file is later opened with
    O_TRUNC, the buffers will then be invalidated and the mapping's error
    set such that a subsequent fsync will return error. I think this is
    incorrect, as there was no writeback between the open and fsync.
    
    Add a new mark_buffer_write_io_error operation that sets the flag and
    the error in the mapping at the same time. Replace all calls to
    set_buffer_write_io_error with mark_buffer_write_io_error, and remove
    the places that check this flag in order to set the error in the
    mapping.
    
    This sets the error in the mapping earlier, at the time that it's first
    detected.
    Signed-off-by: NJeff Layton <jlayton@redhat.com>
    Reviewed-by: NJan Kara <jack@suse.cz>
    Reviewed-by: NCarlos Maiolino <cmaiolino@redhat.com>
    87354e5d
buffer.c 91.3 KB