• J
    HID: wacom: Read and internally use corrected Intuos tool IDs · 82527da3
    Jason Gerecke 提交于
    The 'wacom_intuos_inout' function incorrectly assmebles tool IDs from the
    proximity report, shifting the higher values of the ID four bits farther
    than intended. This problem was not detected until too late, but has not
    caused any issues since the incorrect IDs still fit in a 32-bit integer
    and userspace programs have not required the value to match the hardware
    (just that the values are unique and constant).
    
    The tool IDs reported by the new MobileStudio Pro (or any future
    HID_GENERIC device that supports them) do not suffer from the same
    assembly issue, however. In order for 'wacom_intuos_get_tool_type' to
    work for with both codepaths, we correct this issue internally and
    have 'wacom_intuos_general' only mangle the ID when it is posted to
    userspace.
    Signed-off-by: NJason Gerecke <jason.gerecke@wacom.com>
    Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: NJiri Kosina <jkosina@suse.cz>
    82527da3
wacom_wac.c 117.2 KB