• S
    sky2: RX lockup fix · 798fdd07
    Stephen Hemminger 提交于
    I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX
    lockups while validating the sky2 driver.  The receive MAC FIFO would
    become stuck during testing with high traffic.  One port of the 88E8062
    would lockup, while the other port remained functional.  Re-inserting
    the sky2 module would not fix the problem - only a power cycle would.
    
    I looked over Marvell's most recent sk98lin driver and it looks like
    they had a "workaround" for the Yukon XL that the sky2 doesn't have yet.
    The sk98lin driver disables the RX MAC FIFO flush feature for all
    revisions of the Yukon XL.
    
    According to skgeinit.c of the sk98lin driver, "Flushing must be enabled
    (needed for ASF see dev. #4.29), but the flushing mask should be
    disabled (see dev. #4.115)".  Nice. I implemented this same change in
    the sky2 driver and verified that the RX lockup I was seeing was
    resolved.
    Signed-off-by: NPeter Tyser <ptyser@xes-inc.com>
    Signed-off-by: NStephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: NJeff Garzik <jeff@garzik.org>
    798fdd07
sky2.c 114.9 KB