• A
    x86/efi: Adding efi_printks on memory allocationa and pci.reads · 77e21e87
    Andre Müller 提交于
    All other calls to allocate memory seem to make some noise already, with the
    exception of two calls (for gop, uga) in the setup_graphics path.
    
    The purpose is to be noisy on worrysome errors immediately.
    
    commit fb86b244 ("x86/efi: Add better error logging to EFI boot
    stub") introduces printing false alarms for lots of hardware. Rather
    than playing Whack a Mole with non-fatal exit conditions, try the other
    way round.
    
    This is per Matt Fleming's suggestion:
    
    > Where I think we could improve things
    > is by adding efi_printk() message in certain error paths. Clearly, not
    > all error paths need such messages, e.g. the EFI_INVALID_PARAMETER path
    > you highlighted above, but it makes sense for memory allocation and PCI
    > read failures.
    
    Link: http://article.gmane.org/gmane.linux.kernel.efi/4628Signed-off-by: NAndre Müller <andre.muller@web.de>
    Cc: Ulf Winkelvos <ulf@winkelvos.de>
    Signed-off-by: NMatt Fleming <matt.fleming@intel.com>
    77e21e87
eboot.c 36.2 KB